feat: implement OpenAPI TestAPI generator#1356
Conversation
tschlat
force-pushed
the
issue/1175/open_api_generator
branch
from
4f7cc83 to
e282843
Compare
bbortt
left a comment
bbortt
left a comment
There was a problem hiding this comment.
well done! here are some of my thoughts 😛 only couple of questions and some minor adjustments I think would be good to add.
...t-api-core/src/main/java/org/citrusframework/openapi/testapi/ApiActionBuilderCustomizer.java
Show resolved
Hide resolved
...tor/citrus-test-api-core/src/main/java/org/citrusframework/openapi/testapi/GeneratedApi.java
Show resolved
Hide resolved
...enerator-core/src/test/java/org/citrusframework/openapi/generator/CitrusJavaCodegenTest.java
Show resolved
Hide resolved
...-generator/citrus-test-api-generator-core/src/test/resources/apis/BookService-generated.yaml
Outdated
Show resolved
Hide resolved
test-api-generator/citrus-test-api-generator-core/src/test/resources/citrus-context.xml
Outdated
Show resolved
Hide resolved
...rusframework/openapi/generator/ExpectedCodeGenIT/expectedgen/rest/extpetstore/model/Pet.java
Show resolved
Hide resolved
...ator/ExpectedCodeGenIT/expectedgen/rest/extpetstore/spring/ExtPetStoreBeanConfiguration.java
Outdated
Show resolved
Hide resolved
tschlat
changed the title
bbortt
left a comment
bbortt
left a comment
There was a problem hiding this comment.
thanks for your work. just two more questions, I think.
//lgtm
tschlat
force-pushed
the
issue/1175/open_api_generator
branch
2 times, most recently
from
e4b01b6 to
0f46834
Compare
bbortt
left a comment
bbortt
left a comment
There was a problem hiding this comment.
well, looks good to me! please rebase the branch and solve the conflicts.
tschlat
force-pushed
the
issue/1175/open_api_generator
branch
3 times, most recently
from
652fb2e to
b59a03e
Compare
|
@bbortt any idea why i cannot resolve the open api generator in that build? No problem locally.
|
@tschlat the missing dependency is [INFO] --- openapi-generator:7.14.0:generate (generate-openapi-petstore-files) @ citrus-openapi-codegen ---
Downloading from sonatype-nexus-snapshots: https://oss.sonatype.org/content/repositories/snapshots/org/citrusframework/citrus-test-api-generator-core/4.7.0-SNAPSHOT/maven-metadata.xml
Downloading from sonatype-snapshots: https://oss.sonatype.org/content/repositories/snapshots/org/citrusframework/citrus-test-api-generator-core/4.7.0-SNAPSHOT/maven-metadata.xml
Downloading from sonatype-snapshots: https://oss.sonatype.org/content/repositories/snapshots/org/citrusframework/citrus-test-api-generator-core/4.7.0-SNAPSHOT/citrus-test-api-generator-core-4.7.0-SNAPSHOT.pom
[WARNING] The POM for org.citrusframework:citrus-test-api-generator-core:jar:4.7.0-SNAPSHOT is missing, no dependency information available
Downloading from sonatype-snapshots: https://oss.sonatype.org/content/repositories/snapshots/org/citrusframework/citrus-test-api-generator-core/4.7.0-SNAPSHOT/citrus-test-api-generator-core-4.7.0-SNAPSHOT.jaredit: because it's |
bbortt
force-pushed
the
issue/1175/open_api_generator
branch
from
19ef70e to
feafef3
Compare
|
acutally it was that the module has been renamed from |
|
omg |
|
@christophd we've merged this because (in contrary to the previous PRs) it didn't touch existing code that deep. it's just the new maven plugin core (not the plugin itself). if something's not good in your 👀 , please let us know. we can deliver patches, of course. now follows the very last PR with the actual plugin and documentation. then we must update citrusframework/citrus-simulator#315. and finally, were done. |
2 participants
Introduce the OpenAPI TestAPI generator